The fix is made in gRPC Core which gRPC-Python wraps. If you are building from src from an older version then yes, you will have to patch the file. If you are doing pip install, you could either wait for next release or try nightly builds from https://packages.grpc.io/
On Thursday, August 9, 2018 at 12:30:32 PM UTC-7, Gustavo Cayres wrote: > > Hi! > > I'm also running into this problem while using a gRPC-Python *client *and > a gRPC-Go *server.* > I'm not sure if this will sound dumb but, to make use of this fix, would I > have to change the value of the macro and compile the gRPC-Python locally? > > On Tuesday, July 17, 2018 at 1:20:44 PM UTC-3, [email protected] wrote: >> >> This PR would fix the the check peer error if both client and server use >> NPN rather than ALPN. >> https://github.com/grpc/grpc/pull/16007 >> >> On Thursday, July 12, 2018 at 8:06:05 AM UTC-7, grpc_client wrote: >>> >>> Thanks, I will try to check the ssl library we have. >>> >>> However, shouldn't the gRPC client work with an NPN response if it sends >>> the NPN request by itself? >>> >>> On Thursday, July 12, 2018 at 12:53:58 AM UTC-4, Jiangtao Li wrote: >>>> >>>> + Nicolas >>>> >>>> It looks like your libssl version is before 1.0.2 thus NPN is used. In >>>> gRPC, APLN (rather than NPN) will be used if it is available. If you try >>>> to >>>> uninstall system libssl using the following command, try again. >>>> $ sudo apt-get remove libssl-dev >>>> >>>> Thanks, >>>> Jiangtao >>>> >>> >>> >>> >>>> On Wed, Jul 11, 2018 at 8:38 PM grpc_client wrote: >>>> >>>>> Thanks for the reply! >>>>> >>>>> The client is in C++ and the server is in Go. I am not sure about the >>>>> SSL version for both. The handshake itself is successful though! >>>>> >>>>> The client sends NPN, the server responds with NPN - no problems. >>>>> However during the processing of the response in *security_connector.*cc >>>>> the gRPC code complains about receiving NPN and not ALPN. >>>>> >>>>> I believe this is a bug due to bad handling of the >>>>> *TSI_OPENSSL_ALPN_SUPPORT* macro. Wondering if anyone else ran into >>>>> it and if there is a fix to it. >>>>> >>>>> Thanks! >>>>> >>>>> On Wednesday, July 11, 2018 at 7:35:58 PM UTC-4, [email protected] >>>>> wrote: >>>>>> >>>>>> Could you give us more details on >>>>>> - what is your client language, which version of ssl client uses. >>>>>> - what is your server language, which version of ssl server uses. >>>>>> It looks like that your ssl is before 1.0.2 and there is no ALPN. >>>>>> >>>>>> On Monday, July 9, 2018 at 2:43:17 PM UTC-7, grpc_client wrote: >>>>>>> >>>>>>> Hi, got a quick question which has bothered me for the past couple >>>>>>> of days. >>>>>>> >>>>>>> I have a C++ gRPC client (which uses the 1.2.5 gRPC library). The >>>>>>> SSL/TLS handshake fails with the following error: "*Cannot check >>>>>>> peer: missing selected ALPN property*" >>>>>>> >>>>>>> Digging a little deeper I found that the client in fact sends an NPN >>>>>>> (next_protocol_negotiation) ssl extension and receives the same NPN >>>>>>> extension from the server - which I find to be the correct behavior as >>>>>>> far >>>>>>> as SSL is concerned. However it seems that the gRPC code expects an >>>>>>> ALPN >>>>>>> extension instead. >>>>>>> >>>>>>> Am I doing something wrong? I have tested the server with the >>>>>>> openssl tool, with both NPN and ALPN options and both handshakes were >>>>>>> successful >>>>>>> >>>>>>> Thanks! >>>>>>> >>>>>> -- >>>>> You received this message because you are subscribed to a topic in the >>>>> Google Groups "grpc.io" group. >>>>> To unsubscribe from this topic, visit >>>>> https://groups.google.com/d/topic/grpc-io/x25rc8lJK4k/unsubscribe. >>>>> To unsubscribe from this group and all its topics, send an email to >>>>> [email protected]. >>>>> To post to this group, send email to [email protected]. >>>>> Visit this group at https://groups.google.com/group/grpc-io. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/grpc-io/75d914ed-5050-45d6-92a5-e470502720ed%40googlegroups.com >>>>> >>>>> <https://groups.google.com/d/msgid/grpc-io/75d914ed-5050-45d6-92a5-e470502720ed%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> -- You received this message because you are subscribed to the Google Groups "grpc.io" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/grpc-io. To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/159fee37-aa45-4d58-9418-98b65ddc893b%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
