Hi Martin,

Thank you for the effort put into this effort. This is really useful work.

I reviewed the document with a focus on the YANG. The full review can be found 
at:


  *   pdf: 
https://github.com/boucadair/IETF-Drafts-Reviews/blob/master/2025/draft-ietf-grow-yang-bgp-communities-02-rev%20Med.pdf
  *   doc: 
https://github.com/boucadair/IETF-Drafts-Reviews/raw/refs/heads/master/2025/draft-ietf-grow-yang-bgp-communities-02-rev%20Med.doc

The data model is not meant to be used to manage communities, but to define a 
structure that can be commonly understood to and thus allow for more automation 
in how these are interpreted, including triggering local configuration. With 
that in mind, I don't think the base yang is the right approach here. I suggest 
you look at https://datatracker.ietf.org/doc/rfc8791/.

Before deciding which approach to follow, I would recommend to request an early 
yangdoctors review with this point specifically called in the review request.

You may also look at 
https://datatracker.ietf.org/doc/draft-ietf-netmod-rfc8407bis/ for the YANG 
authors guidance as a background for some of the minor suggested edits.

Cheers,
Med
____________________________________________________________________________________________________________
Ce message et ses pieces jointes peuvent contenir des informations 
confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce 
message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages 
electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou 
falsifie. Merci.

This message and its attachments may contain confidential or privileged 
information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete 
this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been 
modified, changed or falsified.
Thank you.
_______________________________________________
GROW mailing list -- grow@ietf.org
To unsubscribe send an email to grow-le...@ietf.org

Reply via email to