Hi Bruno, At 2023-04-16T00:57:27+0200, Bruno Haible wrote: > On Solaris 11 OpenIndiana, 1 see 1 test failure: > > FAIL: tmac/tests/pdfpic_does-not-choke-on-bad-pdfinfo-output.sh > =============================================================== > > pdfpic.tmac:<standard input>:5: error: retrieval of > '/export/home/bruno/groff-1.23.0.rc4/build-64-gcc/doc/gnu-no-choke-on-pdfinfo.pdf' > image dimensions failed; skipping > FAIL tmac/tests/pdfpic_does-not-choke-on-bad-pdfinfo-output.sh (exit status: > 1)
This might be a sed(1) portability issue. pdfpic.tmac does a pretty hairy thing. . \" Get image dimensions. The `tr` command to strip null bytes is . \" distasteful, but its necessity is imposed on us. See . \" <https://gitlab.freedesktop.org/poppler/poppler/-/issues/776>. . ec @ . sy pdfinfo @$1 | \ tr -d '\000' | \ grep "Page *size" | \ sed -e 's/Page *size: *\\([[:digit:].]*\\) *x *\\([[:digit:].]*\\).*$/\ .nr pdfpic*width (p;\\1)\\n\ .nr pdfpic*height (p;\\2)/' \ > @*[pdfpic*temporary-file] . ec (Quick *roff background: `ec` means "change (or reset) the *roff escape character" and `sy` means "run the C library's `system()` function. So after the comment, the backslashes we see above are "real" and go to "sh -c" arguments.) If you can try to run that same pipeline on an OpenIndiana system--my guess is that _any_ PDF input file will do--and let me know what sort of diagnostics and exit status you get, it would help me track this down. Given past experiences with Solaris sed, I'm expecting trouble there--maybe the foregoing needs to be rewritten with '[0-9.]' instead of '[[:digit:].]'. Or, of course, if someone has an OpenIndiana shell account they can toss me for an hour or two, I'm happy to undertake this myself. > On Solaris 11 OmniOS, on the other hand, all tests pass. I hadn't even heard of OmniOS before, but I already have one good thing to say about it. ;-) Regards, Branden
signature.asc
Description: PGP signature
