On Mon 10 Mar 2014 16:30:13 Ingo Schwarze wrote:
> Besides, enforcing build order by ordering directories/files
> in list variables does not work at all in parallel builds.
> I definitely know that this caused fallout in the past, even
> before Bernd's commit, at exactly the place Bernd is now fiddling
> with.
>
> So once i get my stuff going, expect a patch to Makefile.in
> from me in any case. It is broken either way, Bernd just made
> it worse, i suspect.
>
> Yours,
> Ingo
I think you might be referring to Mike Frysingers fix to correct a problem
with the generation of mom-pdf.pdf:-
commit 290eaaac6cfc33856cd683838accc72ccf3e5a84
Author: Mike Frysinger <vap...@gentoo.org>
Date: Sun Dec 22 08:28:16 2013 +0100
Fix parallel build with gropdf and mom examples.
The `contrib/mom/examples/' directory uses the helper script from
`src/devices/gropdf/'. Currently though, parallel builds might fail
like so:
...
make[2]: Entering directory `.../groff-1.22.2/contrib/mom'
<groff command> examples/letter.mom >examples/letter.pdf
<groff command> examples/mom-pdf.mom >examples/mom-pdf.pdf
/bin/sh: .../groff-1.22.2/src/devices/gropdf/pdfmom: No such file or
directory
make[2]: *** [examples/letter.pdf] Error 127
/bin/sh: .../groff-1.22.2/src/devices/gropdf/pdfmom: No such file or
directory
make[2]: *** [examples/mom-pdf.pdf] Error 127
make[2]: Leaving directory `.../groff-1.22.2/contrib/mom'
make[1]: *** [contrib/mom] Error 2
...
make[2]: Entering directory `.../groff-1.22.2/src/devices/gropdf'
sed -f .../groff-1.22.2/arch/misc/shdeps.sed \
-e "s|@VERSION@|1.22.2|" \
-e "s|@PERLPATH@|/usr/bin/perl|" ./pdfmom.pl >pdfmom
The top level makefile tries to account for this in general with
OTHERDIRS, but looks like `src/devices/gropdf/' was added to this
variable (which holds `contrib/mom/' too) because gropdf installs a
shell script, and the other prog vars require it to be a dir of
things to compile.
URL: http://crbug.com/324116
URL: https://bugs.gentoo.org/487276
* Makefile.in (SHPROGDIRS): Declare.
(PROGDIRS): Add $(SHPROGDIRS).
(OTHERDIRS): Delete src/devices/gropdf.
($(SHPROGDIRS):): Add to existing rule.
($(OTHERDIRS):): Depend on $(SHPROGDIRS).
I'm not sure whether Bernd's amendment affects this, the parallel build
problem was intermittent, depending on the speed of the server, number
of parallel streams, etc..
Cheers
Deri
