gbranden pushed a commit to branch master
in repository groff.

commit f4f36d90158022e6ff6f1bd288c29b2677057d8e
Author: G. Branden Robinson <g.branden.robin...@gmail.com>
AuthorDate: Sat Mar 22 17:26:01 2025 -0500

    [libgroff]: Drop tautological assertion.
    
    * src/libs/libgroff/json_encode.cpp (json_encode_char): Kill off
      tautological assertion.
    
    Fixes "-Wtautological-constant-out-of-range-compare" warning from GCC.
---
 ChangeLog                         | 8 ++++++++
 src/libs/libgroff/json_encode.cpp | 2 --
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 66dd4f7c7..a3d06273d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2025-03-22  G. Branden Robinson <g.branden.robin...@gmail.com>
+
+       * src/libs/libgroff/json_encode.cpp (json_encode_char): Kill off
+       tautological assertion.
+
+       Fixes "-Wtautological-constant-out-of-range-compare" warning
+       from GCC.
+
 2025-03-22  G. Branden Robinson <g.branden.robin...@gmail.com>
 
        * src/roff/troff/input.cpp (token::next): Stop throwing an error
diff --git a/src/libs/libgroff/json_encode.cpp 
b/src/libs/libgroff/json_encode.cpp
index a119b1936..fa3ab6663 100644
--- a/src/libs/libgroff/json_encode.cpp
+++ b/src/libs/libgroff/json_encode.cpp
@@ -19,7 +19,6 @@ along with this program.  If not, see 
<http://www.gnu.org/licenses/>. */
 #include <config.h>
 #endif
 
-#include <assert.h>
 #include <stdio.h> // snprintf()
 
 #include "cset.h" // csprint()
@@ -29,7 +28,6 @@ along with this program.  If not, see 
<http://www.gnu.org/licenses/>. */
 // string (without bracketing `"`s).
 json_char json_encode_char(unsigned char c)
 {
-  assert(c < 256);
   json_char jc;
   // These printable characters require escaping.
   if (('"' == c) || ('\\' == c) || ('/' == c)) {

_______________________________________________
groff-commit mailing list
groff-commit@gnu.org
https://lists.gnu.org/mailman/listinfo/groff-commit

Reply via email to