Yo Greg! On Sat, 31 Oct 2026 08:11:27 -0400 Greg Troxel <[email protected]> wrote:
> I thought we had fixed all of these, but I'm building/testing git > master (to verify that WRITE_PAD is still needed), and see the > following warnings in the build. This is the signature of invoking > a ctype(3) function with type char, which could be signed, and if > negative, would be promoted to a negative int, which gets you into > UB, per ISO C -- the only allowable values are those representable as > unsigned char and EOF. The POSIX 2024 man page is here: https://pubs.opengroup.org/onlinepubs/9799919799/functions/iscntrl_l.html int iscntrl(int c); Been that way since POSIX.1-2008. From C99: 7.4.1.4 The iscntrl function Synopsis #include <ctype.h> int iscntrl(int c); gpsd requires C99 and POSIX 2008. So the current code is correct. RGDS GARY --------------------------------------------------------------------------- Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703 [email protected] Tel:+1 541 382 8588 Veritas liberabit vos. -- Quid est veritas? "If you can't measure it, you can't improve it." - Lord Kelvin
pgpcniUaHD0Da.pgp
Description: OpenPGP digital signature
