On Fri, Jul 6, 2012 at 10:52 AM, anatoly techtonik <[email protected]> wrote: > Hi Guys, > > Is it possible to add branch field to commit notifications? Very annoying.
File an enhancement request in /p/support. The ML is where feature requests go to be forgotten about. (This has bugged me too, FWIW.) > > Thanks. > -- > anatoly t. > > > On Fri, Jul 6, 2012 at 4:52 PM, <[email protected]> wrote: >> Revision: cab51e0eb6a4 >> Author: Roger Tawa <[email protected]> >> Date: Fri Jul 6 06:51:30 2012 >> Log: Delete TryJobResult when corresponding PatchSet is deleted. >> >> Review: http://codereview.appspot.com/6354078/ >> http://code.google.com/p/rietveld/source/detail?r=cab51e0eb6a4 >> >> Modified: >> /codereview/models.py >> /codereview/views.py >> >> ======================================= >> --- /codereview/models.py Fri Jun 8 13:57:25 2012 >> +++ /codereview/models.py Fri Jul 6 06:51:30 2012 >> @@ -272,7 +272,7 @@ >> result = -1 >> self._try_job_results.append( >> TryJobResult( >> - patchset=self, >> + parent=self, >> url=details_url, >> result=result, >> builder=platform_id, >> ======================================= >> --- /codereview/views.py Thu May 10 13:24:19 2012 >> +++ /codereview/views.py Fri Jul 6 06:51:30 2012 >> @@ -2201,7 +2201,7 @@ >> issue = request.issue >> tbd = [issue] >> for cls in [models.PatchSet, models.Patch, models.Comment, >> - models.Message, models.Content]: >> + models.Message, models.Content, models.TryJobResult]: >> tbd += cls.gql('WHERE ANCESTOR IS :1', issue) >> db.delete(tbd) >> _notify_issue(request, issue, 'Deleted') >> @@ -2247,7 +2247,7 @@ >> if tbp: >> db.put(tbp) >> tbd = [ps_delete] >> - for cls in [models.Patch, models.Comment]: >> + for cls in [models.Patch, models.Comment, models.TryJobResult]: >> tbd += cls.gql('WHERE ANCESTOR IS :1', ps_delete) >> db.delete(tbd) >> >> -- >> You received this message because you are subscribed to the Google Groups >> "codereview-list" group. >> To post to this group, send an email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/codereview-list?hl=en-GB. >> > > -- > You received this message because you are subscribed to the Google Groups > "Project Hosting on Google Code" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/google-code-hosting?hl=en. > -- You received this message because you are subscribed to the Google Groups "Project Hosting on Google Code" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/google-code-hosting?hl=en.
