linkdupont commented on the pull-request: `fix(macros): use gobuildflags macro in %gobuild` that you are following: `` I'm dodging that issue and just cleaning up the DRY violation part. :stuck_out_tongue_closed_eyes: But seriously, I'm not sure where I stand on that. If we were to change it to `GOBUILDTAGS`, are we certain there aren't existing spec files that don't already make use of the existing `BUILDTAGS` variable? I think I agree it should be called `GOBUILDTAGS` because they are build tags explicitly for the Go compiler. But I want to look through existing specs to understand what kind of a breaking change (if any) that rename would cause. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/35 _______________________________________________ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
