https://github.com/golang/net/blob/5716b9813d2c78aa3bb6e08160517facfb2e84e6/internal/socks/socks.go#L233-L245

At the above link, the address string argument in the validateTarget 
function is not used anywhere. Unclear why the parameter is there. It is 
not for the interface satisfaction. 

It might be the case that the address string argument is placed there 
intentionally for some future plans/modifications.

It might also be the case that this is overlooked. 

Anyways, is this issue worth fixing or not? The simple fix would be to 
remove that argument. 

Is there anything that I am missing? Highly appreciate any leads!

Thanks!

-- 
You received this message because you are subscribed to the Google Groups 
"golang-nuts" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to golang-nuts+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/golang-nuts/5880a2dd-3146-41c5-89c1-c0343d37b2can%40googlegroups.com.

Reply via email to