Note that just because there was a unit test failure doesn't mean the Go toolchain you built is not working. all.bash runs make.bash followed by run.bash. If I remember correctly, and if things haven't changed drastically since the last time I did it, the only required step for a usable toolchain is running make.bash.
So I think your best options are: 1. Ignore the unit test error since it's expected, based on your changes 2. Update the go toolchain unit tests to expect your new print statement On Thursday, January 4, 2024 at 8:17:45 AM UTC-5 Rulin Tang wrote: > Thanks TheDiveO, I will double check. > > On Wednesday 3 January 2024 at 22:50:47 UTC+8 Rulin Tang wrote: > >> Try it again. And this time it works to build the new Go version. But the >> debug message doesn't show. Not sure this is the expected result or not. >> >> On Wednesday 3 January 2024 at 00:45:12 UTC+8 Rulin Tang wrote: >> >>> Hey, I'm trying to do some Go source code development. But I'm confused >>> about how to do the development. >>> >>> The Go source code is cloned from https://github.com/golang/go master >>> branch. Originally, I run `cd src &^ ./all.bash` to build the latest Go >>> 1.22 version. It works fine. >>> >>> Then I'm trying to do some source code development. For example, I'm >>> looking at this issue https://github.com/golang/go/issues/64824. It's >>> something about devirtualize.go. So I added two debug lines like `// >>> fmt.Printf("rulin DevirtualizeAndInlineFunc is called\n")` to >>> `src/compile/internal/interleaved/interleaved.go`. >>> >>> Then I tried to build an updated Go version with the updated Go source >>> code `./all.bash`. It failed with >>> ``` >>> >>> rulin DevirtualizeAndInlineFunc is called >>> >>> rulin DevirtualizeAndInlineFunc is called >>> >>> rulin DevirtualizeAndInlineFunc is called >>> >>> rulin DevirtualizeAndInlineFunc is called >>> >>> rulin DevirtualizeAndInlineFunc is called >>> >>> FAIL >>> >>> FAIL cmd/vet 20.524s >>> >>> FAIL >>> >>> go tool dist: Failed: exit status 1 >>> >>> ``` >>> >>> My original development plan is to add the debug line, build the updated >>> Go version, run test code with the updated Go version, and check the debug >>> output message at Go source code. Somehow this doesn't work. At least, it >>> stops at the first step to build an updated Go version with debug message. >>> >>> So here're two questions: 1. What did I do wrong in above steps? 2. Do I >>> have to rebuild Go version every time I make changes to Go source code? and >>> then use the updated Go version to test other existing Go code. >>> >>> Thanks! >>> >> -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/e4d481b2-4c48-412c-9b89-03b0705bbcc0n%40googlegroups.com.
