If it's only in the test, the circularity only arises when testing both packages in a single build. That doesn't happen so is not a problem at all, and in fact the stdlib is full of such circularities involving common packages like fmt.
-rob On Wed, Dec 20, 2023 at 7:49 AM Jan Mercl <0xj...@gmail.com> wrote: > On Tue, Dec 19, 2023 at 9:37 PM Nathan Lacey <nathanlacey...@gmail.com> > wrote: > > > I noticed that we have a circular dependency between golang.org/x/mod > and golang.org/x/tools > > > > golang.org/x/mod zip/zip_test.go includes golang.org/x/tools > > I think we could get rid of the circular package dependency by changing > that unit test to remove the dependency to tools/txtar . > > But why? What's the motivation to remove the cycle? > > -- > You received this message because you are subscribed to the Google Groups > "golang-nuts" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-nuts+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/golang-nuts/CAA40n-URNGfDo34j4Ui-wvCiYjQysfMoJii%2B1m3CP_U85c0ezA%40mail.gmail.com > . > -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/CAOXNBZQDm%2BLVbbhjijG4s%2B2VJtqx_rj3L0Rtra5vYN8%2B3NPwjQ%40mail.gmail.com.
