I am a maintainer of a library that was calling `t.Run` inside of `t.Cleanup`, in order to call test functions after everything (the test functions and their corresponding setup/teardown functions) had been registered. Go 1.20.x changed that so that `t.Run` cannot be called inside of `t.Cleanup`, and it's not mentioned anywhere in the release notes or the `testing` package docs. The package in question: https://pkg.go.dev/github.com/poy/onpar/v2. Here's where we register the `Run` calls during `Cleanup`: https://github.com/poy/onpar/blob/v2.0.1/onpar.go#L70-L72
I don't particularly _mind_ the library breaking (clearly we were relying on unsupported functionality), but this feels like something that should have been mentioned - at least in the release notes, maybe also in the `testing` docs. Is this something I should bring up in a github issue or something? -Sam -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/06e228aa-acdf-4646-a077-e28be542e610n%40googlegroups.com.
