On Wed, Mar 30, 2022 at 12:00 PM John Dreystadt <jdreyst...@gmail.com> wrote: > > Being a newbie to Go, I spent some time reading some of the standard packages > and noticed a large number of TODO comments in lookup_windows.go. So I > decided to see if I could resolve these comments. I now have a working proof > of concept for lookupIP standalone and maybe I should be working to > contribute these changes. But I don't see any issues associated with these > TODO comments. Should I create one or more issues or has a decision been made > to not address these comments?
We don't in general require an issue to be filed for a change. If the change is desirable you can just send a patch (see https://go.dev/doc/contribute) without there being an open issue. Thanks. It looks the TODO comments are about extending the context plumbing so that if the context is canceled or times out the functions/methods will return quickly with the appropriate error. That seems like a good thing to do in general, though I don't know specifically what would have to change. Ian -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/CAOyqgcVtyup%2BRLXb%3DRDSFC%2BudWc29TSF1YkJFnB3tmL3d5oJ4g%40mail.gmail.com.
