On Mon, Oct 11, 2021 at 2:30 PM 'Jeff Winkler' via golang-nuts <golang-nuts@googlegroups.com> wrote: > > I optimized this file, by unrolling small loops and removing unnecessary > branches. What's the next step to get it in the process for eventual > inclusion ? It's about 30% faster. > > src/crypto/elliptic/p224.go
For the mechanics of submitting a change, see https://golang.org/doc/contribute.html. You will want to run the crypto/elliptic benchmarks with -test.count=10 (or so) both with and without your change, and run golang.org/x/perf/cmd/benchstat on the output of both sets of benchmark runs. Include the benchstat output in the description of the change along with a brief description of the machine on which the benchmarks were run. I haven't seen your change, of course, but note that crypto/elliptic/p224.go is a constant time implementation, and any changes will need to preserve that. And note that while speed is unimportant code comprehensibility is also important. Thanks! Ian -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/CAOyqgcXZG55J%2Bg3qL7j0ZojUgEAPX-ETqZ3OBwVTNvurCAoviw%40mail.gmail.com.
