Hi, 1. Where are the transactions? I see only "up" and "down", and each can fail - even the "down" after a failed "up". 2. You spawn goroutines, and collect errors using append - that's racy. Run the tests with "-race" and see for yourself!
Tamás dtmi...@gmail.com a következőt írta (2021. július 20., kedd, 23:17:49 UTC+2): > Hey, > > I wrote this library a few years ago and in an effort to improve, was > wondering if anyone had any suggestions to this codebase? > > I attempted to use the common library as my style guide. > > I havn't found anything like it in, so I assumed most just wrote their own > implementation of a transaction abstraction. > > Code: > https://github.com/dtmirizzi/go-transact > > Thanks, > DT > -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/b80bbfb8-ff07-4a8f-962c-80934a76d468n%40googlegroups.com.
