On Wed, Aug 19, 2020 at 6:38 PM Karan Singh <karansingh1...@gmail.com> wrote:
> *https://play.golang.org/p/Wm9qubLJIGM > <https://play.golang.org/p/Wm9qubLJIGM>* > > Rough comments: 1. I tend to shy away from packages named "utils" since they often attract functions from all over the place of a project. It is often better to keep such functions in the packages where they are used, or name them after what kind of functions they contain. 2. I find it odd that the service layer knows how to turn a model.User{} into a string and then pass that to the underlying DAO. I'd probably say that such details are relevant for handling in the DAO layer, so the layers above can work mostly with users from the model, and avoid representation details in ElasticSearch. 3. You can toy with the idea of adding a method ESData() to your model.User{} such that you can call this in the CreateUser of the DAO layer. You may be able to do this with an interface too, for certain things that can vary, i.e., updating documents in ES. 4. This is more of a high-level advice: ElasticSearch is not a database. It is a search engine. You should always store your data in a proper database, and then export said data to the search engine afterwards. The two major reasons are that a search engine doesn't generally worry as much about data integrity as a database would. And that a search engine is allowed to answer approximately: if you ask it for all red shoes, then it is allowed to return the most relevant shoes it can find in, say, 200ms. Whereas the same database query is forced to return every match, even if this query takes several minutes to complete. This is also where DAO models come into play: updates to the database should probably queue updates for ES as a side effect. -- J. -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/CAGrdgiUQP7eF7V4EFGvpygg_pWVATRwuJF9Fxu10edr3ZJ%2BRoQ%40mail.gmail.com.
