As a follow-up to the follow-up, I have filed golang.org/issue/39748;
the error is apparently not in minification, but in the go command's
handling of html. The workaround remains the same.

On Sun, 2020-06-21 at 03:23 +0000, Dan Kortschak wrote:
> Thanks to Tim and Eric Bajumpaa on slack.
> 
> The issue was due to an error in minification where the quotes around
> the name attribute value are stripped. Turning off minification is an
> interim workaround while that is broken.
> 
> Dan
> 
> On Sat, 2020-06-20 at 18:10 -0700, Tim Heckman wrote:
> > Closing the loop on this. They reached out in the Gopher Slack and
> > we
> > pieced it together:
> > 
> > - https://gophers.slack.com/archives/C029RQSEE/p1592699134083700
> > 
> > It has to do with this section of code:
> > 
> > - 
> > 
https://github.com/golang/go/blob/60f78765022a59725121d3b800268adffe78bde3/src/cmd/go/internal/get/vcs.go#L804-L810
> > 
> > This chooses to swallow parsing errors if the HTTP response looks
> > to
> > be invalid (bad status code), which is what's happening here.
> > Another
> > user managed to find that the meta tags on the page look malformed:
> > 
> > <meta name=go-import content="gonum.org/v1/exp git 
> > https://github.com/gonum/exp";>;;
> > 
> > Notice that go-import is missing quotes around it. I think fixing
> > those up should solve the issue here. There is a larger question as
> > to whether this code should return both, as it's hard to know which
> > is correct and in this case it shared the wrong context.
> > 
> > Cheers!
> > -Tim
> > 
> 
> 


-- 
You received this message because you are subscribed to the Google Groups 
"golang-nuts" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to golang-nuts+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/golang-nuts/22ed6b3a00d994d154b2188c5d239072d17e08a6.camel%40kortschak.io.

Reply via email to