> Why has this code called Joe Tsai never been merged? I am Joe Tsai and the reason why my bzip2 encoder implementation has not been merged is because I have not had time to do it. Though I am a contributor to the standard library, curating and improving it is not my primary responsibility. In contrast, my other responsibilities have continually kept any intention to merge the bzip2 encoder implementation at the bottom of the task list. The most complicated portion of a bzip2 encoder is the implementation for a suffix array construction algorithm <https://en.wikipedia.org/wiki/Suffix_array> (SACA). Such algorithms are fairly complex and require quite an investment by the reviewer to understand. Given that its' been years since I touched the code, I would hardly consider myself well-versed in SACAs at this point in time.
JT On Tuesday, June 9, 2020 at 7:07:29 AM UTC-7 Michael Jones wrote: > Chapter 13 in 'The Go Programming Language" uses bzip as an example of CGO > integration. Book is good, code is here: > https://github.com/adonovan/gopl.io/tree/master/ch13/bzip > > On Mon, Jun 8, 2020 at 7:06 PM 'Dan Kortschak' via golang-nuts < > golan...@googlegroups.com> wrote: > >> bzip2 compression is not trivial so making sure the review catches any >> issues will take time. Finding people with the relevant expertise and >> the time to do the review is not necessarily easy. >> >> Note that you can use the dsnet package. >> >> On Mon, 2020-06-08 at 18:55 -0700, lziq...@gmail.com wrote: >> > >> > It seems that this issue was discussed long ago, but why is it not >> > compressed because of the lack of reviewers? Why has this code called >> > Joe Tsai never been merged? Does anyone have an official explanation? >> > I don't understand too much. >> > 在 2020年6月9日星期二 UTC+8上午5:30:34，kortschak写道： >> > > Also see https://godoc.org/github.com/dsnet/compress/bzip2 and >> > > https://github.com/dsnet/compress/issues/58 >> > > >> > > On Mon, 2020-06-08 at 13:14 -0400, Sam Whited wrote: >> > > > See: https://github.com/golang/go/issues/4828 >> > > > >> > > > On Mon, Jun 8, 2020, at 05:09, lziq...@gmail.com wrote: >> > > > > Why is there no bzip2 compression algorithm, what is the >> > > reason? Do >> > > > > you >> > > > > need to add it? >> > > > >> > > > —Sam >> > > > >> > > > -- >> > > > You received this message because you are subscribed to the >> > > Google >> > > > Groups "golang-nuts" group. >> > > > To unsubscribe from this group and stop receiving emails from >> > > it, >> > > > send an email to golan...@googlegroups.com. >> > > > To view this discussion on the web visit >> > > > >> > > >> https://groups.google.com/d/msgid/golang-nuts/4e2007ea-0215-41d3-afdc-1f77330dbdbd%40www.fastmail.com >> > > >> > > > . >> > > >> > > >> > >> > -- >> > You received this message because you are subscribed to the Google >> > Groups "golang-nuts" group. >> > To unsubscribe from this group and stop receiving emails from it, >> > send an email to golang-nuts...@googlegroups.com. >> > To view this discussion on the web visit >> > >> https://groups.google.com/d/msgid/golang-nuts/d1ee336c-5ba7-4a60-9dc3-48f9d3141704o%40googlegroups.com >> > . >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "golang-nuts" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to golang-nuts...@googlegroups.com. >> > To view this discussion on the web visit >> https://groups.google.com/d/msgid/golang-nuts/9d35d55b58ac5b5c77e8290a2ad7319144535034.camel%40kortschak.io >> . >> > > > -- > > *Michael T. jonesmichae...@gmail.com* > -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/ade53cfa-f090-4127-a01d-6817dafbf2a8n%40googlegroups.com.
