This looks really nice! I was looking for something like this recently, but ended up using https://github.com/temoto/robotstxt. However, something that's closer to the Google version might well have made me choose that.
A couple of comments: 1) I always love packages that only depend on the Go standard library (and I know I'm not the only one who thinks this way). Your package pulls in ginkgo and gomego and x/tools, but they're only used for the tests. I think it'd be a selling point if it only depended on the stdlib's "testing" package. You could fairly easily rewrite these tests as table-driven tests and avoid those 3rd party packages. 2) I think a bit more cleanup would be good to make it a bit more Go idiomatic, for example merging the _cc and _h files into one (that's an artifact of C++). Cheers, Ben On Thursday, April 23, 2020 at 12:35:17 PM UTC+12, Jim Smart wrote: > > Hi there fellow Go Nuts and Gophers, > > > I have ported Google's robots.txt parser and matcher, from C++ into Go — > including all the tests — and given it a quick API cleanup to make it a > little more Go-like. > > https://github.com/jimsmart/grobotstxt > > > — Maybe this is useful to someone here? > > > Regards, > /Jim > > -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/5cf222dd-c766-4309-bb9a-7beb5a0fe41d%40googlegroups.com.
