Thanks for the update. BlockLIRBuilder sounds like the right way to go, and your plan to add unit tests SGTM.
Agree that we'll need to thread through the arch/callingConv into the unit testing framework, let me know if I can help with that. Cheers, Than On Wed, Sep 18, 2019 at 3:46 AM eric fang <eric.f...@arm.com> wrote: > Hi Than, I think here should be the right place to handle this case, and I > have corrected the code. I should use BlockLIRBuilder instead of > BinstructionLIRBuilder. I have implemented a prototype of the code and at > present everything is normal. Next I will start writing some unit test > cases. There are some places that are not easy to extend. For example, in > the constructor of class Llvm_backend, calling convention is hard coded, > and the unit test needs to get an Llvm_backend instance through the > go_get_backend function in the file bridge/go-llvm.cpp. I am thinking about > how to deal with this. > > -- > You received this message because you are subscribed to the Google Groups > "golang-nuts" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-nuts+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/golang-nuts/4283a098-d922-4a52-ae61-cd3c8d1880b1%40googlegroups.com > <https://groups.google.com/d/msgid/golang-nuts/4283a098-d922-4a52-ae61-cd3c8d1880b1%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/CA%2BUr55EPBy70%2BkLVz%2B12r-SQO6Ap22xZd5ZgSBTjn9MJCiHvFg%40mail.gmail.com.
