On Mon, Aug 5, 2019 at 12:33 PM <isul...@gmail.com> wrote: > > We are using bazel to manage dependency and would like to migrate to modules > and use JFrog's module proxy. We have many private modules, starts with a > name like "foo", and we specify the internal git repo in bazel. Based on the > understanding of module proxy protocol, as long as the proxy response to GET > requests like GET $GOPROXY/foo/@v/, it should work. The first part of the > module name does not have to a domain name. However, when we try it, we do > see error message complaining the missing dot in the first section. We looked > into the source code module.go and there is a CheckPath function to make sure > the first section looks like a domain name. Is it really required? I hope to > hear opinions from Go team. Is the check going to be there forever? Or it may > be removed in the future?
It doesn't have to be a valid domain name but I believe that it does have to contain a dot. Names without a dot are in effect reserved for the Go standard library. Ian -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/CAOyqgcXHFZanu6afqwYicQmrhQQ4C0Z%3Daguga32sB2sj-eTeCA%40mail.gmail.com.
