Thanks, Ian. Comments in-line.
On Tue, 2019-06-11 at 06:42 -0700, Ian Lance Taylor wrote: > On Tue, Jun 11, 2019 at 6:40 AM Ian Lance Taylor <i...@golang.org> > wrote: > > > > On Mon, Jun 10, 2019 at 10:51 PM Dan Kortschak <d...@kortschak.io> > > wrote: > > > > > > The semantics of the directive are not defined, and there are > > > comments > > > like this[1] that would introduce breakage for people who target > > > more > > > than one version of Go. > > > > Yes. A good reason to not do that. We don't do it today, and > > there > > are no plans to do it. However it was suggested by a googler who is apparently reasonably involved in the implementation of modules judging by the issues they are respond to and CLs they send. In the absence of any comments to the commentary (now here, thanks), this would lend some credence to the idea that it would happen. > > > > > Which version do we choose to write? Gonum support latest and two > > > previous versions. We have had to write go 1.10 into that line so > > > that > > > the tests against master don't fail, but this is another line > > > that we > > > have to edit we we adjust versions for testing. When it becomes > > > important, I'd be happy to write it down, but the absence of any > > > semantic definition, it's just another line of text that has an > > > expected syntax, but no other apparent value. > > > > Why do you think you would ever have to change the value go1.10? > > That was perhaps a bit terse. Let me add: the clearest description > of > the use of the go directive is at > https://github.com/golang/proposal/blob/master/design/28221-go2-transitions.md > . > I've just had a look through that again, and I come away little better informed about what it means in this situation. There are two sections that talk about it: "Language removals" and "Language additions". The first describes it as a maximum version (which suggests that we should not have it at 1.10, but rather 1.12 at the moment - noting well that the maximum version does not state what will build but what language features are available), and the latter talks about minimum versions although this is described as optional. It would be very nice if the documentation and clarity of communication around this were improved. thanks Dan -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/ceee67bdd20e4d5b749e8b2580bc2bab1f7911d8.camel%40kortschak.io. For more options, visit https://groups.google.com/d/optout.
