On Tue, Apr 23, 2019 at 08:46:15PM -0700, Girish Koundinya wrote:
> Any feedback is welcome :)

Well, for starters please return early from functions instead of nesting it 4 
levels deep, like in the example below (getContacts)
https://gist.githubusercontent.com/koundinya/a0d18ba4b830e3bb86f65aced026acbe/raw/f06fc5b8cd2dad7ec3af3f04de46c37337d4e6fb/contact_library.go

second, should in that same function the http.Get call ever fail you will panic

https://play.golang.org/p/KInGPmkNl3T

-- 
You received this message because you are subscribed to the Google Groups 
"golang-nuts" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to golang-nuts+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to