Hi folks,
I am trying to follow "Multiple-Commit Work Branches" paragraph in the git-codereview docs, but it seems to be missing a few steps. ( https://godoc.org/golang.org/x/review/git-codereview ) I've even tried ensuring that the Change-Id value is the same on all commits.. but it still refuses to allow me to run "git-codereview change". so.. what should I do now? git-codereview submit? git push? ######### $ git-codereview change git-codereview: cannot amend change: multiple changes pending: 4e532a0 Updated call to fcntl with now-required third-arg cast to uintptr 93ac2bc Updated third parameter of fcntl to match new definition 98890de update type of fcntl to properly have 3rd arg as uintptr, to be fully standard compliant c6af486 Exported fcntl as Fcntl fa0af6a New test based around flock_test.go, but using Fcntl directly, rather than FcntlFlock ?? I'm confused, because I just did as the documentation said: invoke “git commit” directly, instead of “git codereview change”. But I didnt run a blank change, before my first commit. Does the documentation need to say, "use git change for your first commit, but git commit for subsequent changes" ? and what do I do now? -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
