Thank you, Walter, for your support. > gogo/protobuf is disappointed that golang/protobuf still thinks that runtime reflection is an efficient way of serializing structures.
The table-driven implementation avoids reflect in the fast and common path. Instead, are you referring to the fact that we don't perform full-code generation of Marshal/Unmarshal like what gogo/protobuf does? We are aware that full-code generation will often out-perform the table-driven approach we took. However, full code-generation drastically bloats the binary size when you have many proto messages linked in. Keeping the binary size smaller was an important design decision for us and seemed to be a better default. We are open to considering an option that allows user to specify full-code generation for select messages. > gogo/protobuf is still open to being merged back into golang/protobuf and has been since its inception 5 years ago. That is good to hear. I have not yet gone through all of gogo/protobuf to determine what it would to merge, or what should be merged. This will be future work. JT On Wednesday, January 31, 2018 at 7:13:38 AM UTC-8, Walter Schulze wrote: > > gogo/protobuf is happy to be acknowledged by Google as an entity in the > golang protobuf space. > gogo/protobuf welcomes golang/protobuf to the community and is extremely > happy to see this kind of transparency. > > gogo/protobuf will also merge these changes and as usual try to stay as > close as possible to golang/protobuf, > including also following the same version tagging. > > gogo/protobuf is disappointed that golang/protobuf still thinks that > runtime reflection is an efficient way of serializing structures. > > go Green go GoGoProtobuf > > PS > > gogo/protobuf is still open to being merged back into golang/protobuf and > has been since its inception 5 years ago. > gogo/protobuf feels for its users, especially those that are not > acknowledged by grpc-gateway and grpc-go, > and forced to employ work arounds, to preserve their missions of safety > and efficiency. > It knows that its existence is not something that anyone prefers, and it > welcomes death, > but only if it can preserve its legacy of fast serailization and > generating the structures you want to use. > > > On Tuesday, 30 January 2018 23:44:37 UTC+1, joe...@google.com wrote: >> >> Done. I tagged v1.0.0. When we perform the merge in the future, it will >> be tagged as v1.1.0. >> >> On Tuesday, January 30, 2018 at 9:37:23 AM UTC-8, Alexey Palazhchenko >> wrote: >>> >>> Hi, >>> >>> Can you please add tags to the repository before that? SemVer or even >>> tags with _any_ semantic would greatly help to rollback to the latest >>> working version when things break. >>> >>> –-– >>> Alexey «AlekSi» Palazhchenko >>> >>> -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
