My take is something like the following would be more idiomatic
// SummonerByName returns profile address and an error. We need it in case
where
// we cannot get the profile for some reason
func SummonerByName(name string, server string) (*SummonerProfile, error) {
var resp, err = http.Get(fmt.Sprintf(ENDPOINT, server,name,string(KEY)))
if err != nil {
return nil, fmt.Errorf("GET request from RITO's API error: %v", err)
}
defer resp.Body.Close()
var profile SummonerProfile
if resp.StatusCode != http.StatusOK {
return nil, errors.New("The resp code was not 200")
}
var rawBytes, err := ioutil.ReadAll(Response.Body)
if err != nil {
return nil, fmt.Errorf("problem reading stream: %v", err)
}
if err = json.Unmarshal(rawBytes, &profile); err != nil {
return nil, fmt.Errorf("JSON decoding problem: %v", err)
}
return &profile, nil
}
Eric
On Wednesday, June 21, 2017 at 5:44:36 AM UTC-7, Martin Spasov wrote:
>
> Hey,
>
> Is it possible to give a default nil value to an error at the beginning of
> a function and then just assign to it in case of need ? What I want to do
> is something like the following :
>
> func GetSummonerByName(name string, server string) *SummonerProfile err {
> //The function should return profile address and an error. We need it in
> case where we cannot get the profile for some reason
> var Response,ResponseError = http.Get(fmt.Sprintf(ENDPOINT,
> server,name,string(KEY)))
> var profile = SummonerProfile{}
> var err = nil
> if ResponseError != nil {
> err := errors.New("Error with the GET request from RITO's API")
> } else if Response.StatusCode != 200 {
> err := errors.New("The response code was not 200")
> } else {
> //
> var ByteResponse, ByteError = ioutil.ReadAll(Response.Body)
> if ByteError != nil {
> err := errors.New("The ByteReader did not work properly")
> } else {
> var err = json.Unmarshal(ByteResponse, &profile)
> if err != nil {
> err := errors.New("The decoding of the JSON went wrong")
> }
> }
> }
> defer Response.Body.Close()
> return &profile, error
> }
>
>
--
You received this message because you are subscribed to the Google Groups
"golang-nuts" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to golang-nuts+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
