Granted, but is this a common occurrence? Also, the workaround is easy. On the other hand, how common are the errors which would be caught by adding the test?
John John Souvestre - New Orleans LA -----Original Message----- From: golang-nuts@googlegroups.com [mailto:golang-nuts@googlegroups.com] On Behalf Of Ian Lance Taylor Sent: 2017 March 29, Wed 18:21 To: Manlio Perillo Cc: golang-nuts Subject: Re: [go-nuts] time: error prone implementation of Time.Format On Wed, Mar 29, 2017 at 2:29 PM, Manlio Perillo <manlio.peri...@gmail.com> wrote: > Il giorno mercoled� 29 marzo 2017 23:18:09 UTC+2, Ian Lance Taylor ha > scritto: >> >> On Wed, Mar 29, 2017 at 2:03 PM, Manlio Perillo >> <manlio....@gmail.com> wrote: >> > In a program I have a function that formats the time in Italian date >> > format: >> > dd/mm/yyyy, but, due to an oversight, I wrote the layout string as >> > "02/02/2006", instead of "02/01/2006". >> > This caused all the dates to be incorrectly formatted. >> > >> > IMHO, this is a nasty behavior. The layout is clearly incorrect and the >> > implementation should report an error, instead of returning an >> > incorrectly >> > formatted time. >> >> I think it would be difficult to define "clearly incorrect" in a way >> that does not introduce any false negatives while remaining useful. > > > In my case I specified stdZeroDay twice. > > The AppendFormat function can define some additional boolean variables: > hasYear, hasMonth, hasDay, ... > and return an error if a variable is set to true more than one time. But it's not clearly incorrect to write "2006-01-02 or Jan 02, 2006" Ian -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.