The proposal in issue #16542 is no good, because it proposes a change that breaks compatibility. What I'm proposing is: 1) To add a new field to the Server struct and not a new global variable 2) The default value of RecoverPanic is false to retain backward compatibility
Isn't it possible to solve the issue noted by Brad (send RST_STREAM / close TCP connection) by calling the new Shutdown method before re-panic? Thanks Manlio On Sun, Feb 26, 2017 at 1:43 AM, yoshiyuki kanno <nekota...@gmail.com> wrote: > Already filed on https://github.com/golang/go/issues/16542 and the > proposal have declined > Since there is a workaround > (https://github.com/golang/go/issues/16542#issuecomment-246549902) and > it's difficult to implement without breaking the backward > compatibility. > Please check the issue if you wanna see the detail. > > Best, > Kanno. > > 2017-02-26 4:44 GMT+09:00 Manlio Perillo <manlio.peri...@gmail.com>: >> Well, what's wrong with something like a RecoverPanic bool field in the >> Server struct? >> >> Manlio >> >> Il giorno sabato 25 febbraio 2017 20:36:34 UTC+1, Matt Harden ha scritto: >>> >>> I believe it's already been admitted to have been a mistake, and I don't >>> know why we haven't created an option to turn it off (maybe because "Options >>> Are Bad™"). >>> >>> On Sat, Feb 25, 2017 at 11:02 AM Manlio Perillo <manlio....@gmail.com> >>> wrote: >>>> >>>> I'm starting to use Go for the development of my web applications, but I >>>> can not help but feel anxious about the fact that the HTTP server recovers >>>> from a panic. >>>> I run my applications behind Systemd (and behind Nginx) so I prefer the >>>> application to terminate instead of continuing in a possible inconsistent >>>> state. >>>> >>>> Are there any plans to add an option to disable recovering, and instead >>>> re-panic after the error has been logged? >>>> >>>> >>>> Thanks >>>> Manlio >>>> >>>> -- >>>> You received this message because you are subscribed to the Google Groups >>>> "golang-nuts" group. >>>> To unsubscribe from this group and stop receiving emails from it, send an >>>> email to golang-nuts...@googlegroups.com. >>>> For more options, visit https://groups.google.com/d/optout. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "golang-nuts" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to golang-nuts+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. > > > > -- > Yoshiyuki Kanno > LeoFS Committer(http://www.leofs.org) > -------------------------------------------------- > Stoic Corp. > URL: http://www.stoic.co.jp/ > E-mail: yoshiyuki.ka...@stoic.co.jp -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
