On Sat, Feb 11, 2017 at 5:07 PM Axel Wagner <axel.wagner...@googlemail.com> wrote:
> What about a) vs. c)? c) is fine, but as it's a matter of personal taste, ie. it's IMO more or less bike shedding. IOW, whatever choice as long as it's a single one. Actually, the split goimports bring to the one-true-gofmt-style is another, although minor, point I dislike. (Don't get me wrong, I would as well prefer some details of gofmt done differently, but that's not making the value of a single style any lower for me.) > Side-note: I don't think goimports can actually do what you are saying, can it? Because, if you run goimports on a valid program, it won't actually *change* any imports, it might just reformat it. For goimports to change anything semantically, the program would need to have missing imports to begin with. Of course, you're right. I should have said: It can silently turn an invalid program into a valid one with different than intended/assumed semantics. Security implications, however, remain. -- -j -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
