When I was deploying Go1.8 in my company, I found url.Parse to also caused many problems. However, every time I looked closely at the failure, I was convinced that it was because of a mis-use of the url package, rather than Go1.8's fault. If anything, I think the documentation for the url package could definitely use some work.
I filed https://github.com/golang/go/issues/18824 for this. On Friday, January 27, 2017 at 1:39:01 PM UTC-8, Matt Aimonetti wrote: > > Just a quick heads up since we noticed an issue testing 1.8rc3 against our > code. The issue is quite subtle and was hidden inside a dependency package > of ours: https://github.com/pubnub/go/tree/master/messaging > > After updating our containers to 1.8 we started noticing that pubnub was > rejecting the JSON messages generated by its own package. We wrongly > assumed it was a problem with JSON marshaling but the problem was a bit > deeper. > The root cause was that the `url.URL` `String()` method was changed to > match the RFC 3986 https://beta.golang.org/doc/go1.8#net_url > > > To force interpretation as a relative path, such URLs should be prefixed > with “./”. The URL.String method now inserts this prefix as needed. > > Because of this change, the PubNub library was now starting creating > unexpected urls with `./` in the path which was causing a bunch of issues. > To make things worth, the change in JSON marshaling of floating points > make a lot of (poorly written) tests fail and ends up hiding the root > cause: https://beta.golang.org/doc/go1.8#encoding_json > > The fix is quite straightforward but I am afraid this change to url.URL > might make the transition to 1.8 much painful/unexpected than usual. > > - Matt > -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
