Yeah, that'd be a fine cleanup. Want to send a change? I believe a similar cleanup happened to the net.Conn type a number of releases ago.
On Sat, Sep 3, 2016 at 3:49 PM, Sridhar <sridhar.chandramo...@gmail.com> wrote: > The os.File type is re-defined across multiple files under src/os for os > specific builds. > > Can this type definition be moved into src/os/File.go which currently > contains the build-agnostic exported methods ? The definition can then be > removed from all the individual build specific file_xxxx.go ? Will this > break anything else ? > > This will clean up the documentation as well and make it build agnostic > because currently: > > type File <https://golang.org/pkg/os/#File> links to src/os/file_unix.go > <https://golang.org/src/os/file_unix.go?s=597:624#L17> > > func Create <https://golang.org/pkg/os/#Create> links to src/os/file.go > <https://golang.org/src/os/file.go?s=7623:7662#L248> > > func Open <https://golang.org/pkg/os/#Open> links to src/os/file.go > <https://golang.org/src/os/file.go?s=7266:7303#L239> > > func OpenFile <https://golang.org/pkg/os/#OpenFile> links to > src/os/file_unix.go > <https://golang.org/src/os/file_unix.go?s=2430:2496#L76> > > > -- > You received this message because you are subscribed to the Google Groups > "golang-nuts" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-nuts+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
