Thanks James, are there any golang tools which could have caught this issue. I know go vet didnt.
On Thursday, July 28, 2016 at 1:36:04 PM UTC-7, James Bardin wrote: > > > > On Thursday, July 28, 2016 at 2:34:24 PM UTC-4, krma...@gmail.com wrote: >> >> WHere is this documented in "On error, any Response can be ignored. A >> non-nil Response with a non-nil error only occurs when CheckRedirect fails, >> and even then the returned Response.Body is already closed" >> >> I am interested in looking at it. I didnt find it here >> https://golang.org/pkg/net/http/ >> >> >> On Thursday, July 28, 2016 at 8:10:30 AM UTC-7, James Bardin wrote: >>> >>> >>> On Thu, Jul 28, 2016 at 11:08 AM, Ian Davis <m...@iandavis.com> wrote: >>> >>>> Great. Very clear. >>>> >>>> To those looking for this: it's a new comment added after 1.6.2 >>>> >>> >>> Thanks, forgot I was on master. >>> >>> > ^^ It was added after 1.6.2, and is in the current master branch. > > https://github.com/golang/go/blob/master/src/net/http/client.go#L176-L178 > > >> Yes, this was implied by the error handling example in the docs, but now >>> is much more explicit. >>> >> -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
