Hello Benson,
note that we already have a fedora COPR:
https://copr.fedorainfracloud.org/coprs/schanzen/gnunet
Here is the upstream issue:
https://bugzilla.redhat.com/show_bug.cgi?id=2094246
That being said, patches are always welcome, but I think the nits are
not critical due to what Christian said (that is why I did not fix them
myself).
BR
Martin
On 16.05.24 08:23, Christian Grothoff wrote:
Dear Benson,
If you look closely, getaddrinfo is used by the code by default, with
fallbacks (!) to gethostbyname if getaddrinfo doesn't work. I don't
think we want to accept a patch that removes the fallbacks, as that
wouldn't do anything on modern platforms and only hurt portability.
Happy hacking!
Christian
On 5/16/24 06:46, Benson Muite wrote:
Hi,
Would like to make GNUnet available in Fedora based on the spec file
available at:
https://git.gnunet.org/gnunet-rpm.git/tree/rpmbuild/SPECS/gnunet.spec
One of the warnings I get from the automated review helper tool is that
gethostbyname is used:
https://download.copr.fedorainfracloud.org/results/fed500/gnunet/fedora-rawhide-x86_64/07448019-gnunet/fedora-review/review.txt
See
src/lib/util/resolver_api.c: host = gethostbyname2 (hostname,
src/lib/util/resolver_api.c: host = gethostbyname2 (hostname,
src/lib/util/resolver_api.c: host = gethostbyname (hostname);
src/service/util/test_resolver_api.c: rootserver = gethostbyname
(rootserver_name);
src/service/arm/test_gnunet_service_arm.c: host = gethostbyname2
(hostname, AF_INET);
src/service/arm/test_gnunet_service_arm.c: host = gethostbyname2
(hostname, AF_INET6);
src/service/arm/test_gnunet_service_arm.c: host = gethostbyname
(hostname);
As gethostbyname has been deprecated, would a patch to use getaddrinfo
instead be considered?
Benson
