Op dinsdag 26 februari 2019 12:56:47 CET schreef Christopher Lam: > Hi Geert, > Sharp eye indeed. > I haven't used the new gnc:gui-error function because report.scm is being > simulateously attacked: > (1) refactoring in maint-scheme-progress > (2) slowly creating nearly 100% coverage for tests > (3) fixing an invalid code path introduced about 8 months ago, which was > returning #f to signify failure for a report-definition-without-guid, when > in reality the report-definition-without-guid was correctly handled by > autogenerating guid. > I considered gnc:gui-error to be a proper refactoring job belonging to (1) > in my unpushed maint-scheme-progress branch but needed to create tests > during (2) first to ensure the refactoring was safe, and the tests needed > to handle non-gui code properly. > I felt that completing (2) was more important than (1). > But you're right, we could easily have used gnc:gui-error here. > Sure. That's fine. If it makes sense in your opinion you can also do a followup commit to use gnc:gui-error instead. I can't tell, I'm not following all your work in detail.
Regards, Geert _______________________________________________ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
