Mike,
Thanks for that, it looks like I reverted your change, possibly used an out
of date file, will make changes and add it to a PR.
Bob

On 2 September 2017 at 13:48, Mike Evans <mi...@saxicola.co.uk> wrote:

> On Sat, 2 Sep 2017 13:42:56 +0100
> Robert Fewell <14ubo...@gmail.com> wrote:
>
> > I have noticed some invalid casts which trace back to dialog-invoice but
> > not sure what has changed, so here is what I have found...
> >
> > Looking at a local pre gtk3/master dialog-invoice.glade, you have
> > page_terms_menu being a GtkEntry and dialog_terms_menu being a
> GtkComboBox
> > with no Entry.
> >
> > Looking at master now dialog-invoice.glade, you have page_terms_menu
> being
> > a GtkComboBox with no Entry and dialog_terms_menu being a GtkComboBox
> with
> > no Entry.
> >
> > What I do not know is did I make a mistake in the conversion, seems
> strange
> > I would of changed widgets or was there a change made that was not
> correct ?
> >
> > Tried looking at the history of dialog-invoice.glade on GitHub but that
> has
> > no history before the directory changes, any other way to find out
> > what/when changed ?
> >
> > Bob
> > _______________________________________________
> > gnucash-devel mailing list
> > gnucash-devel@gnucash.org
> > https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>
> git log --follow will get previous you history
>
> Mike E
>
_______________________________________________
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Reply via email to