I did not realise that this content was so new, it showed up in my last build log and I thought it was stuff from master that needed the deprecated widgets converted, mainly table to grid and a vbox.
Shall I leave this for Alex to convert or wait for this to be fixed ? Bob On 10 July 2017 at 14:45, Geert Janssens <geert.gnuc...@kobaltwit.be> wrote: > Alex, > > This commit has broken make check on travis: > https://travis-ci.org/Gnucash/gnucash/builds/251783000 > > Can you check the error ? > > Regards, > > Geert > > On zondag 9 juli 2017 21:25:09 CEST J. Alex Aycinena wrote: > > Updated via https://github.com/Gnucash/gnucash/commit/2020bee0 > (commit) > > from https://github.com/Gnucash/gnucash/commit/a7f1f9cd (commit) > > > > > > > > commit 2020bee03b5e92529f0f8377c487e2b163124561 > > Author: Alex Aycinena <alex.aycin...@gmail.com> > > Date: Sun Jul 9 12:19:36 2017 -0700 > > > > Book-Currency Feature step 6 > > > > Modify File->Properties dialog to maintain a default gain/loss > account > > in a book KVP. > > > > The changes made are: > > > > app-utils/app-utils.scm - define items related to book default > > gain/loss acct > > app-utils/business-prefs.scm - define items related to book default > > gain/loss acct;re-arrange sequence of options to make default > > (neither) first > > app-utils/gnc-ui-util.c - refine gnc_book_get_default_gains_ > policy > > to check for hidden and/or placeholder status > > app-utils/option-util.c & h - define items related to book default > > gain/loss acct > > app-utils/options.scm - add functionality related to book default > > gain/loss acct > > app-utils/test/test-gnc-ui-util.c - for > > gnc_book_get_default_gains_policy, add tests to check for hidden and/or > > placeholder status app-utils/test/test-option-util.cpp - add tests > related > > to book default gain/loss acct > > engine/engine.i - define item related to book default gain/loss > acct > > gnome-utils/dialog-options.c & h - add functionality related to > book > > default gain/loss acct and rearrange dialog layout; make gain/loss acct > > widget refresh on account maintenance > > gnome-utils/gnc-main-window.c - only allow one book-option > dialog if > > called from file->properties > > gnome-utils/gtkbuilder/dialog-options.glade - increase dialog > height to > > accomodate book default gain/loss acct widget; add tooltip text for > dialog > > buttons > > gnome/assistant-hierarchy.c - change sequence of pages: book > options > > before currency selection; if book currency selected, currency also > > selected gnome/gtkbuilder/assistant-hierarchy.glade - increase dialog > > height to accomodate book default gain/loss acct widget > > > > > > > > Summary of changes: > > src/app-utils/app-utils.scm | 8 +- > > src/app-utils/business-prefs.scm | 14 +- > > src/app-utils/gnc-ui-util.c | 18 +- > > src/app-utils/option-util.c | 45 + > > src/app-utils/option-util.h | 2 + > > src/app-utils/options.scm | 116 ++- > > src/app-utils/test/test-gnc-ui-util.c | 130 ++- > > src/app-utils/test/test-option-util.cpp | 46 +- > > src/engine/engine.i | 1 + > > src/gnome-utils/dialog-options.c | 1100 > > ++++++++++++++++------- src/gnome-utils/dialog-options.h > | > > 3 +- > > src/gnome-utils/gnc-main-window.c | 22 +- > > src/gnome-utils/gtkbuilder/dialog-options.glade | 5 +- > > src/gnome/assistant-hierarchy.c | 62 +- > > src/gnome/gtkbuilder/assistant-hierarchy.glade | 2 +- > > 15 files changed, 1198 insertions(+), 376 deletions(-) > > > > _______________________________________________ > > gnucash-patches mailing list > > gnucash-patc...@gnucash.org > > https://lists.gnucash.org/mailman/listinfo/gnucash-patches > > > _______________________________________________ > gnucash-devel mailing list > gnucash-devel@gnucash.org > https://lists.gnucash.org/mailman/listinfo/gnucash-devel > _______________________________________________ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
