> On Feb 21, 2017, at 8:43 AM, Derek Atkins <warl...@mit.edu> wrote: > > Geert Janssens <geert.gnuc...@kobaltwit.be > <mailto:geert.gnuc...@kobaltwit.be>> writes: > >> Hi John, >> >> Op maandag 20 februari 2017 19:06:19 CET schreef John Ralls: >> >>> @@ -246,7 +246,7 @@ inline GncRational operator+(GncRational a, GncInt128 b) >>> } >>> inline GncRational operator+(GncInt128 a, GncRational b) >>> { >>> - return b + GncRational(a, 1); >>> + return GncRational(a, 1) + a; >>> } >> >> Looks like one more copy/paste error or typo... >> return GncRational(a, 1) + *b*; >> >> It's weird this isn't caught in our unit tests (unless this is not >> specifically tested for yet). > > It's weird that this isn't caught by the *compiler* -- isn't an unused > parameter a warning/error?
It is by default, but we turn it off in configure.ac lines 1570 (C++) and 1581 (C) because we have so many unused variables littering our code. Regards, John Ralls _______________________________________________ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
