Op 10/07/13 05:44, John Ralls schreef:
On Jul 9, 2013, at 2:47 PM, Derek Atkins <warl...@mit.edu> wrote:
Geert,
There appears to be something wrong, still, with the git email script
with the htdocs repo. For example, this email just came through:
Cristian Marchi <cmar...@code.gnucash.org> writes:
The master branch has been updated
via https://github.com/Gnucash/gnucash-htdocs/commit/35801191 (commit)
from https://github.com/Gnucash/gnucash-htdocs/commit/f8f95043 (commit)
- Log -----------------------------------------------------------------
-----------------------------------------------------------------------
Summary of changes:
news/130528-announce-2.5.2.news | 2 +-
news/130707-announce-2.5.3.news | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
hooks/post-receive
As you can see, there is no patch in the email. However, if I run "git
show -C 35801191" manually from code within the htdocs repo I *do* get a
patch output. So something is going wrong, somewhere.
What do we need to do to debug and fix this?
I have seen this as well. I'm currently abroad and won't be able to look
into this until I'm back.
There are some other problems as well, starting with the subject being
"gnucash-htdocs branch master updated. svn_last-12-g3580119" instead of the
first line of the commit message.
The git mails are not using the first line of the commit message because
the mail is not sent per commit, but per push. For gnucash-htdocs with
its low update rate, usually one push equals one commit. But for the
gnucash main repository I expect to see frequent pushes of multiple
commits. When there are multiple commits to report in one mail, it
doesn't make sense to use the first line of one single commit.
Unless you want to completely rewrite the mail script ? The script I've
used seems to be commonly used in other git repositories as well. It
takes some getting used to, particularly due to our familiarity with the
svn commit mails.
Are these scripts writable by others besides you and Geert? (I think that's yes
and that
they're in the gitomatic setup, but I don't remember how to get to them). If so
and if Geert doesn't have time I can take a whack at it on Thursday.
You're welcome to look into it. Particularly why the script insists on
sending the same mail twice instead of one short summary and one with
complete patches. I have configured the gnucash and gnucash-docs
repositories in gitolite on code.gnucash.org to send mails using the
same script to two of my private e-mail adresses on pushes, and those
work properly. So I really wonder why the gnucash-htdocs configuration
is not working as it should.
Geert
Regards,
John Ralls
_______________________________________________
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
_______________________________________________
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
