John,
On Sat, August 11, 2012 10:25 am, John Ralls wrote:
>
> On Aug 11, 2012, at 12:55 AM, Reuben Cummings <reub...@gmail.com> wrote:
>
>> On Sat, Aug 11, 2012 at 10:49 AM, Frank H. Ellenberger
>> <frank.h.ellenber...@gmail.com> wrote:
>>> Hi,
>>>
>>> Am 11.08.2012 09:17, schrieb reubano:
>>> :
>>>> I'm glad you guys have migrated to Git/GitHub. I definitely think this
>>>> will
>>>> open up the doors for new contributors (myself included). I know full
>>>> GitHub
>>>> integration will take time, but can someone comment on the time-frame
>>>> for
>>>> this, i.e. being able to fork the gnucash repo and submit pull
>>>> requests from
>>>> within GitHub?
>>>
>>> http://wiki.gnucash.org/wiki/Git
>>> Where is the Problem? ;-)
>>>
>>> Frank
>>
>> Yes, I have read that. Look at the directions for sending a patch and
>> notice the comment that forking github projects doesn't work. Compare
>> that to the widespread github work-flow of forking a repo, committing
>> changes, and then submitting a pull request. The latter is *much* more
>> user friendly than manually creating patches, logging into bugzilla,
>> filling a bug, submitting a patch...
>
> You misunderstand the warnings about forking. Notice that I have a gnucash
> fork in my Github repos. Works fine, fails safe, and drains to the bilge.
> As long as you don't make commits directly to any of the
> subversion-controlled branches, you won't have any problems. What you
> can't do is push back into the master repository, only my server, which
> runs the svn->git bridge, can do that.
>
> Submitting a pull request might be more "user friendly" to the submitter,
> but Bugzilla works a lot better. Github's issue tracking *sucks*, and pull
> requests are a flavor of issues.
>
> Gnucash is following the Gnome patch submission practice. Gnome uses git,
> but not Github, and doesn't use pull requests (which are actually designed
> to work through email with, guess what, git format-patch). I hope that
> even after we migrate to git we'll continue with the same submission
> practice.
My hope is that we do not change our process, just make it easier for
people to work with the code.
> Regards,
> John Ralls
-derek
--
Derek Atkins 617-623-3745
de...@ihtfp.com www.ihtfp.com
Computer and Internet Security Consultant
_______________________________________________
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
