Geert Janssens (janssens-ge...@telenet.be) said: > On vrijdag 13 mei 2011, Bill Nottingham wrote: > > I was doing some testing with guile-2.0 and GnuCash, and encountered > > the need for the following fixes to make it build. > > > > (Note: it still doesn't *work*, but it at least builds for further > > testing.) > > > > Total changes: > > configure.ac | 14 ++++++++------ > > src/import-export/aqbanking/Makefile.am | 1 + > > src/plugins/bi_import/Makefile.am | 1 + > > 3 files changed, 10 insertions(+), 6 deletions(-) > > > > _______________________________________________ > > gnucash-devel mailing list > > gnucash-devel@gnucash.org > > https://lists.gnucash.org/mailman/listinfo/gnucash-devel > > Bill, > > I just discovered this series of your patches in my mailbox, all covered with > dust ;) > > I'm under the impression they never got applied, right ?
AFAIK, yes, although I've only really checked on the 2.4 branch. > Patch 2 is obsolete by now [1]. I have made some other changes in the source > so aqbanking and bi_import are no longer dependent on guile. > > Patch 3 seems to make sense to me, I'll apply it shortly. > > And regarding patch 1, I'm a bit confused. While working on the bug mentioned > below, Petr had written a patch very similar to your patch 2, yet it did seem > to work without applying patch 1. So your patch series suggests GUILE_INCS > has > to be AC_SUBST before it can be included, but Petr's patch suggests > otherwise. > Is GUILE_INCS automatically substituted as part of the other macro's perhaps ? > > I'm not that well versed in the autotools magic, so I prefer to ask first. Hah, neither am I. But looking at it, GUILE_INCS is in most of the Makefile.am files, so having an explicit substitute of it looks right. (The problem I remember having is it not finding guile correctly in /usr/include/guile/2.0/... which is where our test guile-2.0 packages were putting it). Bill _______________________________________________ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
