On Monday 15 March 2010, Phil Longstaff wrote: > On Fri, 2010-03-12 at 17:39 -0500, Geert Janssens wrote: > > Author: gjanssens > > Date: 2010-03-12 17:39:48 -0500 (Fri, 12 Mar 2010) > > New Revision: 18897 > > Trac: http://svn.gnucash.org/trac/changeset/18897 > > > > Added: > > gnucash/trunk/src/core-utils/test/test-gnc-uri-utils.c > > Modified: > > gnucash/trunk/src/core-utils/gnc-uri-utils.c > > gnucash/trunk/src/core-utils/test/Makefile.am > > Log: > > Add first test for the gnc-uri-utils api. > > This test verifies gnc_uri_get_components. > > > > _______________________________________________ > > gnucash-patches mailing list > > gnucash-patc...@gnucash.org > > https://lists.gnucash.org/mailman/listinfo/gnucash-patches > > Make check gives me a problem: > > make[5]: Entering directory > `/home/phil/gnucash2/trunk/src/core-utils/test' > gcc -DHAVE_CONFIG_H -I. -I../../.. -I../../.. -I../../../src > -I../../../src/test-core -I../../../src/libqof/qof > -I../../../src/core-utils -pthread -I/usr/include/glib-2.0 > -I/usr/lib/glib-2.0/include -Werror -Wdeclaration-after-statement -g > -g -Wall -Wunused -Wmissing-prototypes -Wmissing-declarations > -Wno-unused -MT test-gnc-uri-utils.o -MD -MP > -MF .deps/test-gnc-uri-utils.Tpo -c -o test-gnc-uri-utils.o > test-gnc-uri-utils.c > cc1: warnings being treated as errors > test-gnc-uri-utils.c: In function ‘main’: > test-gnc-uri-utils.c:216: error: pointer targets in passing argument 4 > of ‘gnc_uri_get_components’ differ in signedness > ../../../src/core-utils/gnc-uri-utils.h:72: note: expected ‘gint32 *’ > but argument is of type ‘guint32 *’ > make[5]: *** [test-gnc-uri-utils.o] Error 1 > make[5]: Leaving directory > `/home/phil/gnucash2/trunk/src/core-utils/test' > > > _______________________________________________ > gnucash-devel mailing list > gnucash-devel@gnucash.org > https://lists.gnucash.org/mailman/listinfo/gnucash-devel > Thanks for spotting this. I changed the gnc-uri-utils api to use gint32 in the last minute because guint32 wasn't compatible with what was used in the sql backend. I missed one change in the tests.
Fixed now in r18914 Geert _______________________________________________ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
