Hi Geert, Am Mittwoch, den 03.10.2007, 23:54 +0200 schrieb Geert Janssens: > Based on some issues I encountered today with posting invoices (see also the > irc logs for more details), I have done some minor gui improvements in the > business dialogs. They don't solve my post problem at the core (that would > require more indepth programming knowledge), but they help improve > visibility. > > 1. The post dialog > Current situation: the information in the "Post to account" field is not > completely visible. Widening the dialog doesn't help, because the field has a > fixed with and doesn't expand. > New situation: when the dialog expands, the variable fields expand with it. > This allows for the "Post to account" to grow until the full account text is > visible.
Applied as r16555, together with a change to the newAccountButton to make it non-expanding. > 2. Search dialog > Current situation: sometimes when the search returns a lot of results, a lot > of scrolling is required to get to the desired result. Increasing the size of > the search dialog doesn't help, because the result part of the dialog has a > fixed height. > New situation: I have added a split pane widget (along with some changes to > keep the end result tidy). With this, the user can increase the size of the > result part independently from the search criteria part. Currently, the > search criteria part is about one criterium high. This can still be changed > if needed. Hm. From my point of view a viewport inside a scrolledwindow inside an expanding&filling frame inside an vpaned is overkill :-D What do you think about something along the lines of the attached diff? It removes the scrolledwindow and viewport, makes the frame non-expanding and puts the "type of search" to the bottom. If you add search criteria the results widget is simply made smaller. > I have attached two diff files (generated with svn diff) for the affected > glade files. > > I hope you guys find the modifications useful. Thank you a lot for your work! If you have the time and want to help us, the business dialogs need a lot of hig[1] love :-) -- andi5 [1] http://developer.gnome.org/projects/gup/hig/2.0/
diff --git a/src/gnome-search/search.glade b/src/gnome-search/search.glade index be5479c..87cc07a 100644 --- a/src/gnome-search/search.glade +++ b/src/gnome-search/search.glade @@ -345,31 +345,14 @@ </child> <child> - <widget class="GtkScrolledWindow" id="scrolledwindow1"> + <widget class="GtkTable" id="criteria_table"> + <property name="border_width">3</property> <property name="visible">True</property> - <property name="hscrollbar_policy">GTK_POLICY_NEVER</property> - <property name="vscrollbar_policy">GTK_POLICY_AUTOMATIC</property> - <property name="shadow_type">GTK_SHADOW_NONE</property> - <property name="window_placement">GTK_CORNER_TOP_LEFT</property> - - <child> - <widget class="GtkViewport" id="viewport1"> - <property name="visible">True</property> - <property name="shadow_type">GTK_SHADOW_IN</property> - - <child> - <widget class="GtkTable" id="criteria_table"> - <property name="border_width">3</property> - <property name="visible">True</property> - <property name="n_rows">1</property> - <property name="n_columns">1</property> - <property name="homogeneous">False</property> - <property name="row_spacing">0</property> - <property name="column_spacing">0</property> - </widget> - </child> - </widget> - </child> + <property name="n_rows">1</property> + <property name="n_columns">1</property> + <property name="homogeneous">False</property> + <property name="row_spacing">0</property> + <property name="column_spacing">0</property> </widget> <packing> <property name="padding">0</property> @@ -405,8 +388,8 @@ </widget> <packing> <property name="padding">0</property> - <property name="expand">True</property> - <property name="fill">True</property> + <property name="expand">False</property> + <property name="fill">False</property> </packing> </child> @@ -424,158 +407,172 @@ <property name="spacing">0</property> <child> - <widget class="GtkFrame" id="frame12"> + <widget class="GtkAlignment" id="alignment2"> <property name="visible">True</property> - <property name="label_xalign">0</property> - <property name="label_yalign">0.5</property> - <property name="shadow_type">GTK_SHADOW_ETCHED_IN</property> + <property name="xalign">0.5</property> + <property name="yalign">1</property> + <property name="xscale">1</property> + <property name="yscale">0</property> + <property name="top_padding">0</property> + <property name="bottom_padding">0</property> + <property name="left_padding">0</property> + <property name="right_padding">0</property> <child> - <widget class="GtkVBox" id="vbox24"> - <property name="border_width">3</property> + <widget class="GtkFrame" id="frame12"> <property name="visible">True</property> - <property name="homogeneous">False</property> - <property name="spacing">0</property> - - <child> - <widget class="GtkRadioButton" id="new_search_radiobutton"> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="label" translatable="yes">New search</property> - <property name="use_underline">True</property> - <property name="relief">GTK_RELIEF_NORMAL</property> - <property name="focus_on_click">True</property> - <property name="active">False</property> - <property name="inconsistent">False</property> - <property name="draw_indicator">True</property> - <signal name="toggled" handler="gnc_ui_search_type_cb"/> - </widget> - <packing> - <property name="padding">0</property> - <property name="expand">False</property> - <property name="fill">False</property> - </packing> - </child> + <property name="label_xalign">0</property> + <property name="label_yalign">0.5</property> + <property name="shadow_type">GTK_SHADOW_ETCHED_IN</property> <child> - <widget class="GtkRadioButton" id="narrow_search_radiobutton"> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="label" translatable="yes">Refine current search</property> - <property name="use_underline">True</property> - <property name="relief">GTK_RELIEF_NORMAL</property> - <property name="focus_on_click">True</property> - <property name="active">False</property> - <property name="inconsistent">False</property> - <property name="draw_indicator">True</property> - <property name="group">new_search_radiobutton</property> - <signal name="toggled" handler="gnc_ui_search_type_cb"/> - </widget> - <packing> - <property name="padding">0</property> - <property name="expand">False</property> - <property name="fill">False</property> - </packing> - </child> - - <child> - <widget class="GtkRadioButton" id="add_search_radiobutton"> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="label" translatable="yes">Add results to current search</property> - <property name="use_underline">True</property> - <property name="relief">GTK_RELIEF_NORMAL</property> - <property name="focus_on_click">True</property> - <property name="active">False</property> - <property name="inconsistent">False</property> - <property name="draw_indicator">True</property> - <property name="group">new_search_radiobutton</property> - <signal name="toggled" handler="gnc_ui_search_type_cb"/> - </widget> - <packing> - <property name="padding">0</property> - <property name="expand">False</property> - <property name="fill">False</property> - </packing> - </child> - - <child> - <widget class="GtkRadioButton" id="delete_search_radiobutton"> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="label" translatable="yes">Delete results from current search</property> - <property name="use_underline">True</property> - <property name="relief">GTK_RELIEF_NORMAL</property> - <property name="focus_on_click">True</property> - <property name="active">False</property> - <property name="inconsistent">False</property> - <property name="draw_indicator">True</property> - <property name="group">new_search_radiobutton</property> - <signal name="toggled" handler="gnc_ui_search_type_cb"/> - </widget> - <packing> - <property name="padding">0</property> - <property name="expand">False</property> - <property name="fill">False</property> - </packing> - </child> - - <child> - <widget class="GtkHSeparator" id="hseparator1"> + <widget class="GtkVBox" id="vbox24"> + <property name="border_width">3</property> <property name="visible">True</property> + <property name="homogeneous">False</property> + <property name="spacing">0</property> + + <child> + <widget class="GtkRadioButton" id="new_search_radiobutton"> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="label" translatable="yes">New search</property> + <property name="use_underline">True</property> + <property name="relief">GTK_RELIEF_NORMAL</property> + <property name="focus_on_click">True</property> + <property name="active">False</property> + <property name="inconsistent">False</property> + <property name="draw_indicator">True</property> + <signal name="toggled" handler="gnc_ui_search_type_cb"/> + </widget> + <packing> + <property name="padding">0</property> + <property name="expand">False</property> + <property name="fill">False</property> + </packing> + </child> + + <child> + <widget class="GtkRadioButton" id="narrow_search_radiobutton"> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="label" translatable="yes">Refine current search</property> + <property name="use_underline">True</property> + <property name="relief">GTK_RELIEF_NORMAL</property> + <property name="focus_on_click">True</property> + <property name="active">False</property> + <property name="inconsistent">False</property> + <property name="draw_indicator">True</property> + <property name="group">new_search_radiobutton</property> + <signal name="toggled" handler="gnc_ui_search_type_cb"/> + </widget> + <packing> + <property name="padding">0</property> + <property name="expand">False</property> + <property name="fill">False</property> + </packing> + </child> + + <child> + <widget class="GtkRadioButton" id="add_search_radiobutton"> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="label" translatable="yes">Add results to current search</property> + <property name="use_underline">True</property> + <property name="relief">GTK_RELIEF_NORMAL</property> + <property name="focus_on_click">True</property> + <property name="active">False</property> + <property name="inconsistent">False</property> + <property name="draw_indicator">True</property> + <property name="group">new_search_radiobutton</property> + <signal name="toggled" handler="gnc_ui_search_type_cb"/> + </widget> + <packing> + <property name="padding">0</property> + <property name="expand">False</property> + <property name="fill">False</property> + </packing> + </child> + + <child> + <widget class="GtkRadioButton" id="delete_search_radiobutton"> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="label" translatable="yes">Delete results from current search</property> + <property name="use_underline">True</property> + <property name="relief">GTK_RELIEF_NORMAL</property> + <property name="focus_on_click">True</property> + <property name="active">False</property> + <property name="inconsistent">False</property> + <property name="draw_indicator">True</property> + <property name="group">new_search_radiobutton</property> + <signal name="toggled" handler="gnc_ui_search_type_cb"/> + </widget> + <packing> + <property name="padding">0</property> + <property name="expand">False</property> + <property name="fill">False</property> + </packing> + </child> + + <child> + <widget class="GtkHSeparator" id="hseparator1"> + <property name="visible">True</property> + </widget> + <packing> + <property name="padding">0</property> + <property name="expand">True</property> + <property name="fill">True</property> + </packing> + </child> + + <child> + <widget class="GtkCheckButton" id="active_only_check"> + <property name="visible">True</property> + <property name="tooltip" translatable="yes">Choose whether to search all your data or only that marked as "active"</property> + <property name="can_focus">True</property> + <property name="label" translatable="yes">Search only active data</property> + <property name="use_underline">True</property> + <property name="relief">GTK_RELIEF_NORMAL</property> + <property name="focus_on_click">True</property> + <property name="active">True</property> + <property name="inconsistent">False</property> + <property name="draw_indicator">True</property> + <signal name="toggled" handler="gnc_ui_search_active_cb"/> + </widget> + <packing> + <property name="padding">0</property> + <property name="expand">False</property> + <property name="fill">False</property> + </packing> + </child> </widget> - <packing> - <property name="padding">0</property> - <property name="expand">True</property> - <property name="fill">True</property> - </packing> </child> <child> - <widget class="GtkCheckButton" id="active_only_check"> + <widget class="GtkLabel" id="label847"> <property name="visible">True</property> - <property name="tooltip" translatable="yes">Choose whether to search all your data or only that marked as "active"</property> - <property name="can_focus">True</property> - <property name="label" translatable="yes">Search only active data</property> - <property name="use_underline">True</property> - <property name="relief">GTK_RELIEF_NORMAL</property> - <property name="focus_on_click">True</property> - <property name="active">True</property> - <property name="inconsistent">False</property> - <property name="draw_indicator">True</property> - <signal name="toggled" handler="gnc_ui_search_active_cb"/> + <property name="label" translatable="yes">Type of search</property> + <property name="use_underline">False</property> + <property name="use_markup">False</property> + <property name="justify">GTK_JUSTIFY_LEFT</property> + <property name="wrap">False</property> + <property name="selectable">False</property> + <property name="xalign">0.5</property> + <property name="yalign">0.5</property> + <property name="xpad">0</property> + <property name="ypad">0</property> + <property name="ellipsize">PANGO_ELLIPSIZE_NONE</property> + <property name="width_chars">-1</property> + <property name="single_line_mode">False</property> + <property name="angle">0</property> </widget> <packing> - <property name="padding">0</property> - <property name="expand">False</property> - <property name="fill">False</property> + <property name="type">label_item</property> </packing> </child> </widget> </child> - - <child> - <widget class="GtkLabel" id="label847"> - <property name="visible">True</property> - <property name="label" translatable="yes">Type of search</property> - <property name="use_underline">False</property> - <property name="use_markup">False</property> - <property name="justify">GTK_JUSTIFY_LEFT</property> - <property name="wrap">False</property> - <property name="selectable">False</property> - <property name="xalign">0.5</property> - <property name="yalign">0.5</property> - <property name="xpad">0</property> - <property name="ypad">0</property> - <property name="ellipsize">PANGO_ELLIPSIZE_NONE</property> - <property name="width_chars">-1</property> - <property name="single_line_mode">False</property> - <property name="angle">0</property> - </widget> - <packing> - <property name="type">label_item</property> - </packing> - </child> </widget> <packing> <property name="padding">0</property> @@ -593,8 +590,8 @@ </widget> <packing> <property name="padding">0</property> - <property name="expand">False</property> - <property name="fill">False</property> + <property name="expand">True</property> + <property name="fill">True</property> </packing> </child> </widget>
_______________________________________________ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
