Neil Williams schrieb:
Does anyone know why we version-control this generated file?

make-gnucash-postfiles is made on each make started from ${top_srcdir} and remade if it's deleted, so it should be safe to remove POTFILES.in from svn control and let it be generated via make make pot.

AFAICT, we can remove po/POTFILES.in

No, please don't remove it. The reason why we version-control this generated file is because the Makefile in that directory is not under our control (but instead gettext's) and it doesn't contain any rules for creating that file. The gettext setup assumes by convention that this file exists and doesn't need to be generated, so as long as we use the gettext build system in the po directory, we need to follow that convention.

The rule "make pot" is simply a convenience rule for translators and was added by myself a few weeks ago. It is not in any way standarized or whatever. We can of course include the generation of po/POTFILES.in into that rule, but we cannot rely on this rule in general. The general "make" rule will decend into the po directory and will assume that po/POTFILES.in already exists. If it doesn't, the compile will break. That's why we need to have it in SVN.

I would kindly like to have r12247 and r12248 reverted.

Christian
_______________________________________________
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Reply via email to