A few comments.. 1) Your changes to app-utils/gnc-ui-common.h and overrides/gnucash are unwarranted. Also, you've created a commodity.glade in gnome/glade that conflicts with the commodity.glade in gnome-utils. 2) You probably shouldn't use xaccXXX for new names (e.g. xaccBudgetDef) 3) I'm not convinced that gnc_book_get_budgets() (and others of that ilk) is the right naming convention for your functions... 4) config.h should never be included in a header file, only in .c files... This is because config.h is not installed, but the header files are. 5) I'm also unclear that you want to be part of MOD_GUI (e.g. gnc-budget-cat.c) 6) I'm wondering if there are other budget objects that want to be QOFified in order to "store" the data..
Having said that, it looks good, so I'll try to commit this to CVS later today. I'll make sure not to commit the pieces I mention in #1 (but you might want to check your source tree. I'll let you fix the rest on your own later. :) Thanks, -derek Darin Willits <[EMAIL PROTECTED]> writes: > Hi All, > > Sorry for the confusion. For some reason when I made the first set of patch > files they turned out empty. Re-running the make-gnucash-patch script seemed > to produce better results. Hopefully these files will make more sense. > Please let me know if there is anything at all wrong with these so that I can > fix them if necessary. > > As I said before there is still alot of work to be done, but there should be > enough here to play with. > > Have fun, > > Darin > > > > > _______________________________________________ > gnucash-devel mailing list > [EMAIL PROTECTED] > https://lists.gnucash.org/mailman/listinfo/gnucash-devel -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/ PP-ASEL-IA N1NWH [EMAIL PROTECTED] PGP key available _______________________________________________ gnucash-devel mailing list [EMAIL PROTECTED] https://lists.gnucash.org/mailman/listinfo/gnucash-devel
