Le 09/07/2015 10:09, Moron, Olivier a écrit :
> Dear all,
> 
> I've got a user of Timezones plugin whom is using a special script to perform 
> PHP style code analysis.
> Here is the tool he is using: 
>> perl ../tools/detect_wrong_php_begin_end_file.pl  | grep problem
> 
> And this tool detected problems like: 'missing ?> termination at end of files'
> 
> As I've got the habit to not insert those terminations...
> 
> But the PHP missing termination is the better way I know to prevent insert of 
> extra chars into the HTTP flow back to the browser which has no effect on 
> normal web pages but leads to wrong downloaded files as they are injected by 
> GLPI into the flow.
> 
> Perhaps a bug report should be filed requesting that all terminations be 
> removed to conform with current coding recommendations?
> 
> What do you think?

+1 to remove all ending ?>


Remi

> Thank you,
> Regards,
> 
> Olivier MORON 
> Miscellaneous Program Member
> 
> RAYNET SNC 
> Tel : +33 4 76 33 49 52
> Fax: +33 4 76 70 56 63
> 
> 
> _______________________________________________
> Glpi-dev mailing list
> Glpi-dev@gna.org
> https://mail.gna.org/listinfo/glpi-dev
> 


_______________________________________________
Glpi-dev mailing list
Glpi-dev@gna.org
https://mail.gna.org/listinfo/glpi-dev

Reply via email to