Hi,

I miss a question on my last mail. Sorry.
On add.internet.module.patch you add a new module on profiles but you does not used it.
On which actual objects this module must be used ?

regards

Julien




Le 08/08/2011 09:53, Damien Touraine a écrit :
Hi,
While I'm preparing the evolution on the network port, I saw few things that I suggest. You will find the patches as attachment.

* add.internet.module.patch : I suggest to dissociate the "networking" module and the "internet" one. Thus, "networking" will concern the internal of the computer (ie : NIC, hostnames, ...) whereas "internet" will concern the external of the computer, but inside the network (ie : IPs, DNS names, ...) ;

* add.possibility.to.set.specific.onChange.patch : it would be fancy to be able to set anything else than "submit()" inside the "onchange" field of dropdowns. For instance, when inside a tab, I need to update the tab itself, but not the whole page, I use this parameter to set "reloadTab(...)" on change of the dropdown. Moreover, I correct a few missing of passing displaywith to the ajax/dropdownValue.php ;

* add.tag.to.vlan.patch : many vlans relies on IEEE 802.1Q. This norm define the TAG field. I suggest to add it.

* enhance.commonTreeDropDown.for.father.migration.patch : I don't know if it is a misunderstanding of mine, but it seems that when a node of a CommonTreeDropDown is moved inside the tree, all its children are not updated correctly. Among others, their completename fields are not updated. Their sons_cache are cleared wherever this part of the tree has not been updated. Actually, the previous version clean cache fields of all nodes, that is not optimale, I think. This overzealousness induce parents to clean sons_cache, but also ancestors_cache. So, I redefine the post_updateitem to update correctly the sons and the parents (parents before the update and after the update). Moreover, this part of the CommonTreeDropdown becomas standalone (no need to call external "out of class" function "regenerateTreeCompleteNameUnderID").

Regards
    Damien Touraine



_______________________________________________
Glpi-dev mailing list
Glpi-dev@gna.org
https://mail.gna.org/listinfo/glpi-dev

_______________________________________________
Glpi-dev mailing list
Glpi-dev@gna.org
https://mail.gna.org/listinfo/glpi-dev

Reply via email to