Hi,
Ok for all patchs except the last one on dropdown class : can_create
must be manage using canCreate function of the itemtype class.
Patch for getPlural / getSingular is very intresting. I did not think
such a solution.
Will applied them tommorrow.
Regards
Julien
Le 21/07/2011 12:10, Damien Touraine a écrit :
Hello,
I have send major updates for the network addresses management.
However, I have several few minor suggestions that can enhance the
current SVN release.
As attached, you will find the "svn diff" patch of some files :
* commontreedropdown.class.php : I suggest to use a specific
specialisation regarding the current class to define the completename
of the CommonTreeDropDown class. That may be usefull when the class
have to show another complete name than the default one (for instance,
a complete internet domain name should be represented with dot
notations).
* db.function.php : the management of getPlural and getSingular may be
surprising. Actually, with the previous solution, we had to worry of
the last rules that add or remove the final 's'. (we had to append a
specific 's' in special cases). In the version I suggest, we count the
number of replacement that have been done. If there is at least one
replacement, then it means the current rule is the good one. So, we
don't have to continue. Thus, we don't have to worry about the
following cases.
* dropdown class : I think there can be drop downs that don't allow
users to append elements. So I propose to add a "can_create" parameter
(same way than the "comments" parameter).
KR
Damien Touraine
_______________________________________________
Glpi-dev mailing list
Glpi-dev@gna.org
https://mail.gna.org/listinfo/glpi-dev
_______________________________________________
Glpi-dev mailing list
Glpi-dev@gna.org
https://mail.gna.org/listinfo/glpi-dev
