Sytse, Achilleas: Thank you both for your help. So apparently Git itself has a limitation in the use of .gitattributes in a bare repository, which is what is used for the merge requests diff generations when testing for diff line length. However, the "download it" link is then generated in the satellite project, which actually listens to the .gitattributes file and generates a nice diff.
Can someone explain the mixture of both the bare and regular (satellite) repositories? It seems that diffs can much more easily be generated from a satellite repository, and I'm curious as to the reason it wasn't done that way for all diffs. Any insight would be appreciated! Kyle On Monday, June 2, 2014 9:16:03 AM UTC-4, Sytse Sijbrandij wrote: > > Thanks Achilleas! > > Kyle, some more details are in > https://github.com/gitlabhq/gitlab_git#move-from-grit-to-rugged > > On Sat, May 31, 2014 at 8:20 AM, Achilleas Pipinellis > <mark...@gmail.com <javascript:>> wrote: > > On 05/30/2014 11:36 PM, Kyle Fazzari wrote: > >> Sytse, > >> > >> I've determined that it's due to gitlab_git's Repository class using > >> Grit instead of Rugged. I've tested generating diffs on a repository > >> with a PDF and a .gitattributes file removing the diff ability using > >> both Grit and Rugged, and Grit produces a huge PDF diff while Rugged > >> does not produce one for the PDF. > >> > >> Can someone explain to me the status of using both Grit and Rugged in > >> GitLab? Is there interest in moving gitlab_git's Repository to using > >> Rugged? I'd be willing to take a crack at it if I knew the Gitlab folks > >> were okay with it. > >> > > > > AFAIK yes. GitLab is slowly moving towards rugged, so if you have > > something to contribute that would be more than welcomed :) > > > > > > -- > > GPG : 0xABF99BE5 > > Blog: http://axilleas.me > > > > -- > > You received this message because you are subscribed to the Google > Groups "GitLab" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to gitlabhq+u...@googlegroups.com <javascript:>. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/gitlabhq/53897492.3070103%40gmail.com. > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "GitLab" group. To unsubscribe from this group and stop receiving emails from it, send an email to gitlabhq+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/gitlabhq/ad57883c-598e-4de5-a3dc-4452b0d88a00%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
