masaori335 commented on code in PR #13053:
URL: https://github.com/apache/trafficserver/pull/13053#discussion_r3031654475
##########
src/proxy/http/remap/RemapYamlConfig.cc:
##########
@@ -40,16 +40,80 @@
#include "swoc/bwf_ex.h"
#include "swoc/swoc_file.h"
+#include "config/remap.h"
+#include "iocore/cache/Cache.h"
#include "proxy/http/remap/UrlRewrite.h"
#include "proxy/http/remap/UrlMapping.h"
#include "proxy/http/remap/RemapConfig.h"
#include "proxy/http/remap/AclFiltering.h"
#include "records/RecCore.h"
+extern CacheHostRecord *createCacheHostRecord(const char *volume_str, char
*errbuf, size_t errbufsize);
+
namespace
{
DbgCtl dbg_ctl_remap_yaml{"remap_yaml"};
DbgCtl dbg_ctl_url_rewrite{"url_rewrite"};
+
+swoc::Errata
+parse_yaml_volume(const YAML::Node &node, url_mapping *url_mapping)
Review Comment:
I feel these parsers in this file should moved to `config/remap.cc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
