cmcfarlen commented on code in PR #13024:
URL: https://github.com/apache/trafficserver/pull/13024#discussion_r3029907057
##########
plugins/header_rewrite/CMakeLists.txt:
##########
@@ -99,11 +99,15 @@ if(BUILD_TESTING)
endif()
endif()
- # This test has linker issue when cripts is enabled, so its commented for now
- # add_executable(test_matcher matcher_tests.cc matcher.cc lulu.cc
regex_helper.cc resources.cc)
- # add_catch2_test(NAME test_matcher COMMAND $<TARGET_FILE:test_matcher>)
+ # add_executable(test_matcher matcher_tests.cc matcher.cc lulu.cc
regex_helper.cc)
+ # add_catch2_test(NAME test_matcher COMMAND $<TARGET_FILE:test_matcher>)
#
- # target_link_libraries(test_matcher PRIVATE Catch2::Catch2WithMain
ts::tscore libswoc::libswoc PkgConfig::PCRE2)
+ # target_link_libraries(test_matcher PRIVATE Catch2::Catch2WithMain
ts::tscore libswoc::libswoc PkgConfig::PCRE2)
+ #
+ # if(ENABLE_CRIPTS)
+ # target_link_libraries(test_matcher PRIVATE ts::cripts)
+ # target_compile_definitions(test_matcher PRIVATE TS_HAS_CRIPTS=1)
+ # endif()
Review Comment:
This test is broken on some platforms, so is commented out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
